config: materialize parameter sets

Description

Dear Thibaut,

Is the following something you could do with relatively small effort (cf. https://github.com/matsim-scenarios/matsim-berlin/issues/33#issuecomment-582500526):

  • Currently, when a config is read from xml, for all the non-standard config groups, the material is first kept in a key,value map.

  • After calling ConfigUtils.addOrCreateModule( config, NonStandardConfigGroup.class ), the existing entries of the non-standard config group are "materialized", i.e. they exist as typed entries afterwards.

  • However, this does not work for parameter sets inside those non standard config groups.

On

branch materializeParameterSetsInConfig

I already wrote a test, ConfigBehaviorTest#testMaterializeAfterReadParameterSets(), in drt config, which is now failing because it does not work.

As said, is this something you could fix with acceptable effort?

Otherwise, I guess that we should at least abort when someone is trying this. Forcing people to instantiate the config with the correct additional config groups from the beginning.

Thanks and all the best

Kai
[Created via e-mail received from: "Nagel, Kai, Prof. Dr." <nagel@vsp.tu-berlin.de>]

Environment

None

Activity

Show:
Thibaut Dubernet
February 6, 2020, 10:52 AM

That should not be complicated. I will have a look at it.

Kai Nagel
February 25, 2020, 1:22 PM

I saw this merged so it seems to be done. THANKS!

Assignee

Thibaut Dubernet

Reporter

Kai Nagel

Labels

Priority

Major
Configure